Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seccomppolicy compiler: cBPF filter comparators #2903

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

seccomppolicy compiler: cBPF filter comparators #2903

wants to merge 1 commit into from

Conversation

marctrem
Copy link
Collaborator

@marctrem marctrem commented Sep 10, 2024 •
edited
Loading

This change introduces the following 4 operators

  • <
  • <=
  • >
  • >=

Those can be use with one immediate value and one sub expression (regardless of the order).

@marctrem marctrem changed the title stub comparators seccomppolicy cBPF filter comparators Sep 10, 2024
@marctrem marctrem changed the title seccomppolicy cBPF filter comparators seccomppolicy compiler: cBPF filter comparators Sep 10, 2024
@marctrem marctrem marked this pull request as ready for review September 10, 2024 18:12
@ripatel-fd
Copy link
Contributor

Can you please squash the changes? Thanks!

@marctrem
Copy link
Collaborator Author

@ripatel-fd I'm surprised that squashing on PR merge is not the default. Will do!

@ripatel-fd
Copy link
Contributor

@marctrem Should I press merge on this?

@mmcgee-jump
Copy link
Contributor

Not yet, I want to actually use it first to make sure

ripatel-fd
ripatel-fd approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripatel-fd ripatel-fd ripatel-fd approved these changes

@nlgripto nlgripto nlgripto approved these changes

@mmcgee-jump mmcgee-jump Awaiting requested review from mmcgee-jump

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marctrem @ripatel-fd @mmcgee-jump @nlgripto